Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/#711: add support to update and refresh attributeGroup #776

Merged
merged 17 commits into from
Jul 13, 2023
Merged

feature/#711: add support to update and refresh attributeGroup #776

merged 17 commits into from
Jul 13, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Mar 1, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

todos

  • resolve lots of ids
  • add setDefinition to list of renamedTypes in Mcdev._retrieveBU()

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via [TASK] Documentation for 5.2 #1007)

@JoernBerkefeld JoernBerkefeld added this to the 4.4.0 milestone Mar 1, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 1, 2023
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Mar 1, 2023
@JoernBerkefeld JoernBerkefeld added the c/attributeSet COMPONENT label Mar 1, 2023
@JoernBerkefeld JoernBerkefeld linked an issue Mar 27, 2023 that may be closed by this pull request
[FEATURE] resolve attributeGroup and attributeSet #711
Closed
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.0.0, 5.1.0 Apr 11, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.1.0, 5.2.0 Jun 6, 2023
@JoernBerkefeld
Merge branch 'develop' into feature/711-update-refresh-attribute-group
50953bf 
# Conflicts:
#	lib/metadataTypes/SetDefinition.js
@github-actions
Copy link

github-actions bot commented Jul 11, 2023 •
edited
Loading

Coverage Report

Commit:67093b5
Base: develop@749f31b

Type Base This PR
Total Statements Coverage  47.96%  48.64%  (+0.68%)
Total Branches Coverage  39.2%  39.6%  (+0.4%)
Total Functions Coverage  53.51%  54.47%  (+0.96%)
Total Lines Coverage  47.89%  48.57%  (+0.68%)
Details (changed files):
File Statements Branches Functions Lines
lib/MetadataTypeDefinitions.js  100%  100%  100%  100%
lib/MetadataTypeInfo.js  100%  100%  100%  100%
lib/index.js  50%  43.45%  50%  49.87%
lib/metadataTypes/AttributeGroup.js  81.48%  60%  100%  81.48%
lib/metadataTypes/AttributeSet.js  90.27%  81.48%  100%  90.27%

@JoernBerkefeld JoernBerkefeld mentioned this pull request Jul 13, 2023
Closed
@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review July 13, 2023 13:55
@JoernBerkefeld JoernBerkefeld merged commit 099557d into develop Jul 13, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/711-update-refresh-attribute-group branch July 13, 2023 14:02
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/attributeGroup COMPONENT c/attributeSet COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] resolve attributeGroup and attributeSet
1 participant
@JoernBerkefeld